Feat(repository json schema) add title to filter schemas#4319
Closed
dougal83 wants to merge 2 commits into
Closed
Conversation
dougal83
force-pushed
the
feat(repository-json-schema)--add-title-to-filter-schemas
branch
from
December 19, 2019 15:42
3bc349b to
f9946d4
Compare
Member
|
@jannyHou , could you please review? Thanks. |
dougal83
force-pushed
the
feat(repository-json-schema)--add-title-to-filter-schemas
branch
from
December 23, 2019 17:31
f9946d4 to
947702c
Compare
add title property to filter schemas(filter, where, scope) in preparation for openapi schema consolidation
dougal83
force-pushed
the
feat(repository-json-schema)--add-title-to-filter-schemas
branch
from
December 23, 2019 18:06
947702c to
9679aa8
Compare
dougal83
deleted the
feat(repository-json-schema)--add-title-to-filter-schemas
branch
January 1, 2020 20:10
dougal83
restored the
feat(repository-json-schema)--add-title-to-filter-schemas
branch
January 1, 2020 20:14
dougal83
deleted the
feat(repository-json-schema)--add-title-to-filter-schemas
branch
January 1, 2020 20:14
Contributor
Author
|
Relocated: #4355 resubmitted. dougal83:feat(repository-json-schema)add-title-to-filter-schemas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding titles to json filter schemas as groundwork toward openapi spec ref consolidation based on title property. See #4290
!! Unable to run tests on local Win10 machine. Is there a docker image that can be used to run tests?
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈